fix(material/autocomplete): not closing when clicking outside while propagation is stopped - #17381
Open
crisbeto wants to merge 1 commit into
Open
Conversation
crisbeto
force-pushed
the
17352/autocomplete-click-outside-capturing
branch
from
July 5, 2020 16:50
a67c5aa to
9721022
Compare
crisbeto
force-pushed
the
17352/autocomplete-click-outside-capturing
branch
from
August 21, 2020 21:19
9721022 to
fc31804
Compare
crisbeto
force-pushed
the
17352/autocomplete-click-outside-capturing
branch
from
January 4, 2021 21:08
fc31804 to
5fa2d4c
Compare
crisbeto
force-pushed
the
17352/autocomplete-click-outside-capturing
branch
from
February 14, 2021 12:53
5fa2d4c to
0d20156
Compare
…ropagation is stopped Fixes the autocomplete panel not closing if the user clicks outside on an element that stops propagation of the `click` event (e.g. a `mat-chip`). Fixes angular#17352.
crisbeto
force-pushed
the
17352/autocomplete-click-outside-capturing
branch
from
March 19, 2022 08:43
0d20156 to
749d3ba
Compare
Contributor
|
It seems like this introduced a new bug where autocompletes can escape being closed. Here's how to reproduce:
I suspect its something to do with the timing / order of the events now that we changed the click handler to the capture phase, maybe adding a |
|
@crisbeto does this problem still exist? |
Member
Author
|
It does, but I haven't had time to come back and try to land this change. |
|
@crisbeto do you know when it would be feasible to have it in release?? |
josephperrott
requested review from
amysorto and
mmalerba
and removed request for
a team
December 18, 2024 17:40
mmalerba
removed their request for review
February 20, 2025 00:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the autocomplete panel not closing if the user clicks outside on an element that stops propagation of the
clickevent (e.g. amat-chip).Fixes #17352.
Caretaker note (crisbeto): ~30 screenshot failures, handful of unit test failures testing for old behaviour