Skip to content

fix(material-experimental/mdc-button): add ::after to reflect active styles - #17283

Merged
mmalerba merged 1 commit into
angular:masterfrom
andrewseguin:mdc-button-state
Oct 3, 2019
Merged

fix(material-experimental/mdc-button): add ::after to reflect active styles#17283
mmalerba merged 1 commit into
angular:masterfrom
andrewseguin:mdc-button-state

Conversation

@andrewseguin

Copy link
Copy Markdown
Contributor

Looks like MDC uses both ::before and ::after to reflect state. They use them in parallel to help reflect the combination of states (e.g. focus + active)

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 3, 2019
@andrewseguin andrewseguin added pr: merge safe target: patch This PR is targeted for the next patch release labels Oct 3, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 3, 2019
@mmalerba
mmalerba merged commit 4dbf9f6 into angular:master Oct 3, 2019
mmalerba pushed a commit that referenced this pull request Oct 8, 2019
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants