build: ensure build-packages-dist script works on macOS #17247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
devversion
changed the title
The `build-packages-dist` script does not seem to work on MacOS because the `cp --no-preserve` flag is not supported by default. This commit switches to a simple `chmod` call in order to make it work in all Bash environments. Additionally the script has been updated to clean previous `npm_package` outputs. This ensures that the version placeholder is properly replaced in the release output. This is necessary due to a bug in `rules_nodejs`. Read more here: bazel-contrib/rules_nodejs#1219
devversion
force-pushed
the
build/ensure-clean-release-output
branch
from
09346cf to
6ef4985
Compare
jelbourn
approved these changes
Oct 1, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
build-packages-distscript does not seem to work on MacOSbecause the
cp --no-preserveflag is not supported by default.This commit switches to a simple
chmodcall in order to make itwork in all Bash environments. Additionally the script has been updated
to clean previous
npm_packageoutputs. This ensures that the versionplaceholder is properly replaced in the release output.
This is necessary due to a bug in
rules_nodejs. Read more here:bazel-contrib/rules_nodejs#1219