Skip to content

build: add mdc prebuilt theme to karma legacy tests #16965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

Adds the MDC prebuilt theme to the karma legacy tests. This is
consistent with what we did for the Bazel tests. It can cause
unexpected differences and confusion when debugging tests in
both Bazel and the legacy job (different visual output).

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Sep 3, 2019
@devversion devversion requested a review from a team as a code owner September 3, 2019 20:33
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 3, 2019
Adds the MDC prebuilt theme to the karma legacy tests. This is
consistent with what we did for the Bazel tests. It can cause
unexpected differences and confusion when debugging tests in
both Bazel and the legacy job (different visual output).
@devversion devversion force-pushed the build/add-prebuilt-theme-karma-legacy branch from baa1eab to 667d33c Compare September 3, 2019 20:35
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 3, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit ff6ee4e into angular:master Sep 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants