Skip to content

build: add dev app proxy server for testing across devices #16935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 1, 2019

We currently can't test the dev app across devices, because the Bazel server doesn't allow us to configure the server host.

These changes add a very simple, temporary, proxy server that runs in parallel to Bazel dev server and proxies all requests to it, while allowing devices to connect to it.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: patch This PR is targeted for the next patch release labels Sep 1, 2019
@crisbeto crisbeto requested review from jelbourn and a team as code owners September 1, 2019 07:50
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 1, 2019
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One comment

We currently can't test the dev app across devices, because the Bazel server doesn't allow us to configure the server host.

These changes adds a very simple, temporary, proxy server that runs in parallel to Bazel dev server and proxies all requests to it, while allowing devices to connect to it.
@crisbeto
Copy link
Member Author

crisbeto commented Sep 4, 2019

Shouldn't be necessary anymore with the new dev server.

@crisbeto crisbeto closed this Sep 4, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants