chore: move e2e tests into component source dirs #16117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
requested review from
andrewseguin,
crisbeto and
josephperrott
as code owners
googlebot
added
the
cla: yes
|
Thanks @devversion for helping with the pile of CI failures! |
jelbourn
added
pr: lgtm
action: merge
devversion
approved these changes
May 28, 2019
|
Awesome! the macro for the e2e tests really reduces the duplication 👍 |
josephperrott
pushed a commit
that referenced
this pull request
Jun 10, 2019
* chore: move e2e tests into component source dirs * move utils in e2e/ to src/e2e-app/ * move e2e tests to the component's src dir * update owners and uses of gulp/bazel * fix some targets I missed when renaming * move e2e test utils under @angular/cdk/testing * fix lint
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
* chore: move e2e tests into component source dirs * move utils in e2e/ to src/e2e-app/ * move e2e tests to the component's src dir * update owners and uses of gulp/bazel * fix some targets I missed when renaming * move e2e test utils under @angular/cdk/testing * fix lint
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm naming e2e test files
*.e2e.spec.tsto differentiate them from unit tests, and adding thee2etag to e2e blaze targets to differentiate those.