Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update "material2" to "components" #15905

Merged
merged 1 commit into from
Apr 25, 2019
Merged

chore: update "material2" to "components" #15905

merged 1 commit into from
Apr 25, 2019

Conversation

jelbourn
Copy link
Member

This should capture things that reference the GitHub repository.
There are many other places we use "material2" that we can clean up in
subsequent changes.

@jelbourn
chore: update "material2" to "components"
d5b9bb4 
This should capture things that reference the GitHub repository.
There are many other places we use "material2" that we can clean up in
subsequent changes.
@jelbourn jelbourn added the target: major This PR is targeted for the next major release label Apr 25, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 25, 2019
devversion
devversion approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crisbeto
crisbeto approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Apr 25, 2019
@jelbourn
Copy link
Member Author

Marking as merge-safe since I confirmed that the code changes only affect comments

@mmalerba mmalerba merged commit fde980c into angular:master Apr 25, 2019
@fxck
Copy link
Contributor

fxck commented Apr 29, 2019

Any info on this? Will the npm package name change as well?

@jelbourn
Copy link
Member Author

We're just changing the repo because it contains more packages than just @angular/material

RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@jelbourn @RudolfFrederiksen
chore: update "material2" to "components" (angular#15905)
1c6dc5e 
This should capture things that reference the GitHub repository.
There are many other places we use "material2" that we can clean up in
subsequent changes.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jelbourn @fxck @crisbeto @devversion @googlebot @mmalerba