fix(stepper): unable to skip step if completed value is overwritten - #15403
Merged
mmalerba merged 1 commit intoOct 2, 2019
Merged
Conversation
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
15310/stepper-completed-override
branch
from
March 6, 2019 20:37
1ece8b1 to
943ecf7
Compare
crisbeto
force-pushed
the
15310/stepper-completed-override
branch
3 times, most recently
from
March 18, 2019 21:46
ff7225c to
ffe1765
Compare
andrewseguin
added
the
P4
Currently we allow for the `completed` value of a step to be overwritten, however setting it to `true` still won't allow the user to skip the step, because the `interacted` flag won't be flipped if they haven't been on a particular step before. Fixes angular#15310.
crisbeto
force-pushed
the
15310/stepper-completed-override
branch
from
June 15, 2019 14:09
ffe1765 to
0e64c4b
Compare
mmalerba
reviewed
Aug 12, 2019
| this._completedOverride = coerceBooleanProperty(value); | ||
| } | ||
| private _customCompleted: boolean | null = null; | ||
| _completedOverride: boolean|null = null; |
Contributor
There was a problem hiding this comment.
is there a reason this was made non-private?
Member
Author
There was a problem hiding this comment.
It's been a long time since I opened this PR, but from what I can tell, it's because CdkStepper also checks it.
Contributor
There was a problem hiding this comment.
Ah ok, yeah sorry was going through my old assigned PRs and found this that I never responded to
mmalerba
approved these changes
Aug 12, 2019
| this._completedOverride = coerceBooleanProperty(value); | ||
| } | ||
| private _customCompleted: boolean | null = null; | ||
| _completedOverride: boolean|null = null; |
Contributor
There was a problem hiding this comment.
Ah ok, yeah sorry was going through my old assigned PRs and found this that I never responded to
mmalerba
added
pr: lgtm
action: merge
mmalerba
pushed a commit
that referenced
this pull request
Oct 8, 2019
…15403) Currently we allow for the `completed` value of a step to be overwritten, however setting it to `true` still won't allow the user to skip the step, because the `interacted` flag won't be flipped if they haven't been on a particular step before. Fixes #15310. (cherry picked from commit bebb9ff)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we allow for the
completedvalue of a step to be overwritten, however setting it totruestill won't allow the user to skip the step, because theinteractedflag won't be flipped if they haven't been on a particular step before.Fixes #15310.