fix(virtual-scroll): move views that are already attached instead of inserting #15348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
Fixes a minor issue in
CdkVirtualScroll
where sometimes views were inserted twice.Fixes some tests that were relying on the fact that an externally requested
ViewContainerRef
would be the same instance as the injectedViewContainerRef
instance (specificallyspyOn
methods were spying on a different instance). This is an implementation detail that is changed in Ivy. Also fixes these tests so that they aren't spying directly onViewContainerRef
method calls (as these are also called internally byViewContainerRef
itself and could change at any time).