Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(virtual-scroll): move views that are already attached instead of inserting #15348

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

kara
Copy link
Contributor

@kara kara commented Mar 1, 2019

This PR does two things:

  1. Fixes a minor issue in CdkVirtualScroll where sometimes views were inserted twice.

  2. Fixes some tests that were relying on the fact that an externally requested ViewContainerRef would be the same instance as the injected ViewContainerRef instance (specifically spyOn methods were spying on a different instance). This is an implementation detail that is changed in Ivy. Also fixes these tests so that they aren't spying directly on ViewContainerRef method calls (as these are also called internally by ViewContainerRef itself and could change at any time).

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 1, 2019
@kara kara added target: major This PR is targeted for the next major release target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release target: minor This PR is targeted for the next minor release labels Mar 1, 2019
@kara kara force-pushed the virtual-scroll branch from cc8a266 to dec1c8b Compare March 1, 2019 01:48
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 1, 2019
@josephperrott josephperrott merged commit 2470a42 into angular:master Mar 4, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants