fix(drag-drop): dragged styling not being removed when exiting component with OnPush - #15266
Merged
Merged
Conversation
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
15233/drag-drop-wrapped-cd
branch
from
February 21, 2019 14:52
455019e to
0854ddc
Compare
jelbourn
added
pr: lgtm
action: merge
crisbeto
force-pushed
the
15233/drag-drop-wrapped-cd
branch
from
February 24, 2019 16:43
0854ddc to
c6b17c6
Compare
…ent with OnPush Fixes the dragged styling not being removed from a drop container, which is wrapped inside a component with `OnPush` change detection, when an item is dragged into a connected container. Fixes angular#15233.
crisbeto
force-pushed
the
15233/drag-drop-wrapped-cd
branch
from
March 8, 2019 23:17
c6b17c6 to
d869f08
Compare
andrewseguin
added
target: minor
andrewseguin
added
target: major
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the dragged styling not being removed from a drop container, which is wrapped inside a component with
OnPushchange detection, when an item is dragged into a connected container.Fixes #15233.