Skip to content

feat(menu): allow focus restoration to be disabled - #15205

Merged
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:15168/menu-focus-restoration
Feb 22, 2019
Merged

feat(menu): allow focus restoration to be disabled#15205
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:15168/menu-focus-restoration

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Allows for focus restoration to be disabled in a menu, similarly to some other components. In some cases restoring focus automatically might not make sense (e.g. if the user closes the menu by selecting something which then opens a dialog) and this allows consumers to customize the behavior as needed.

Fixes #15168.

@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Feb 15, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 15, 2019
Allows for focus restoration to be disabled in a menu, similarly to some other components. In some cases restoring focus automatically might not make sense (e.g. if the user closes the menu by selecting something which then opens a dialog) and this allows consumers to customize the behavior as needed.

Fixes angular#15168.
@crisbeto
crisbeto force-pushed the 15168/menu-focus-restoration branch from 043eb55 to 145df61 Compare February 16, 2019 08:42

@jelbourn jelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 19, 2019
@jelbourn
jelbourn merged commit dfa40fc into angular:master Feb 22, 2019
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option for menu not to return focus to menu trigger on close

3 participants