-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(docs): add aria label to checkboxes in selection example, #15021 #15158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
a281f1f
to
24c1747
Compare
@@ -5,13 +5,15 @@ | |||
<th mat-header-cell *matHeaderCellDef> | |||
<mat-checkbox (change)="$event ? masterToggle() : null" | |||
[checked]="selection.hasValue() && isAllSelected()" | |||
[indeterminate]="selection.hasValue() && !isAllSelected()"> | |||
[indeterminate]="selection.hasValue() && !isAllSelected()" | |||
[aria-label]='checkboxLabel()'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Use double-quote in HTML templates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must've missed it, thanks for pointing it out! It's addressed in the latest commit.
…istent double-quotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #15021
PR adds aria-labels to the check-boxes in the table selection example so they can be read by accessibility tools