Skip to content

fix(docs): password visibility toggle example in form field component… #15129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 22, 2019
Merged

fix(docs): password visibility toggle example in form field component… #15129

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4b6546
fix(docs): password visibility toggle example in form field component…
Suresh918 Feb 8, 2019
703c569
password icon button label changes
Suresh918 Feb 11, 2019
0ecaa84
form field prefix suffix examplel aria label modified
Suresh918 Feb 20, 2019
e6af661
code format changes
Suresh918 Feb 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/material-examples/form-field-prefix-suffix/form-field-prefix-suffix-example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
<div class="example-container">
<mat-form-field>
<input matInput placeholder="Enter your password" [type]="hide ? 'password' : 'text'">
<mat-icon matSuffix (click)="hide = !hide">{{hide ? 'visibility_off' : 'visibility'}}</mat-icon>
<button mat-icon-button matSuffix (click)="hide = !hide" [attr.aria-label]="'Hide password'" [attr.aria-pressed] = hide>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit: omit spaces and add double-quotes:

[attr.aria-pressed]="hide"

<mat-icon>{{hide ? 'visibility_off' : 'visibility'}}</mat-icon>
</button>
</mat-form-field>

<mat-form-field>
Expand Down