Skip to content

Toggle buttons aria labels changes #14999 #15114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 11, 2019
Merged

Toggle buttons aria labels changes #14999 #15114

merged 4 commits into from
Feb 11, 2019

Conversation

Suresh918
Copy link
Contributor

@Suresh918 Suresh918 commented Feb 7, 2019 •
edited
Loading

Fixes #14999

@Suresh918 Suresh918 requested a review from jelbourn as a code owner February 7, 2019 16:41
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 7, 2019
crisbeto
crisbeto reviewed Feb 7, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add "Fixes #14999" to the commit message? Otherwise the issue won't be closed when we merge the PR.

crisbeto
crisbeto approved these changes Feb 9, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 9, 2019
@jelbourn jelbourn merged commit cb7d3b9 into angular:master Feb 11, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toggle buttons in the toggle button example are missing accessible names
4 participants
@Suresh918 @jelbourn @crisbeto @googlebot