fix(calendar): should markForCheck when properties are changed

[andrewseguin]

activeDate and currentView are properties used in the view and the change detector should be aware when they are changed

[crisbeto]

LGTM

[jelbourn]

@andrewseguin are the CI errors real?

[andrewseguin]

Should not be real but Ill see what's going on

Note that the reason this worked before is because the property changes were done by a nested view's event handling. This would propagate and cause this view to be marked dirty and update.

Since these properties may not be changed due to an event, it should not be assumed that the view will be marked dirty and this is valid.

This was discovered due to Ivy-related tests and an appropriate Jira ticket was opened to preserve current behavior.

[andrewseguin]

Looks like I'm seeing the error now - looking into it. Surprised marking for dirty is causing an error....

[andrewseguin]

Looks like the test wasn't right - it was focusing on the wrong element after the view changed.

[jelbourn]

LGTM

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}