Skip to content

test: remove div ngFor in chip list tests - #15101

Merged
jelbourn merged 1 commit into
angular:masterfrom
andrewseguin:chip-list-remove-div-ngfor
Feb 7, 2019
Merged

test: remove div ngFor in chip list tests#15101
jelbourn merged 1 commit into
angular:masterfrom
andrewseguin:chip-list-remove-div-ngfor

Conversation

@andrewseguin

Copy link
Copy Markdown
Contributor

Removes the unnecessary wrapping div containers for some test components. In Ivy, these will not be picked up as ContentChildren since descendants (nested children) are not checked

@andrewseguin andrewseguin added pr: merge safe target: patch This PR is targeted for the next patch release labels Feb 6, 2019
@andrewseguin
andrewseguin requested a review from jelbourn February 6, 2019 18:08
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 6, 2019

@crisbeto crisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 6, 2019
@jelbourn

jelbourn commented Feb 7, 2019

Copy link
Copy Markdown
Contributor

LGTM, be sure to cherrypick into the ivy-2019 branch

@jelbourn
jelbourn merged commit a4c235a into angular:master Feb 7, 2019
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants