fix(slide-toggle): input element should use switch role - #15073
Merged
jelbourn merged 2 commits intoFeb 5, 2019
Conversation
Based on the discussion in angular#14949 and the feedback from a Google a11y expert on what role the underlying input of the `slide-toggle` should use, we now explicitly specify the new `switch` role. This is should improve accessibility because practically the `slide-toggle` is neither always causing an immediately effective value change (like a `button`), nor does its value only become effective on form submission (like a `role="checkbox`) Read more here: https://www.w3.org/TR/wai-aria-1.1/#switch Fixes angular#14949.
devversion
added
Accessibility
googlebot
added
the
cla: yes
Contributor
|
Which screenreaders did you test this with? |
Member
Author
|
@jelbourn I've tested it on VoiceOver: Safari and Chrome, and Narrator: Edge. Everything worked as expected. Just a small difference was that Narrator said |
Set aria-checked attribute for ARIA spec compliance
jelbourn
pushed a commit
that referenced
this pull request
Feb 11, 2019
Based on the discussion in #14949 and the feedback from a Google a11y expert on what role the underlying input of the `slide-toggle` should use, we now explicitly specify the new `switch` role. This is should improve accessibility because practically the `slide-toggle` is neither always causing an immediately effective value change (like a `button`), nor does its value only become effective on form submission (like a `role="checkbox`) Read more here: https://www.w3.org/TR/wai-aria-1.1/#switch Fixes #14949.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #14949 and the feedback from a Google a11y expert on
what role the underlying input of the
slide-toggleshould use, we now explicitlyspecify the new
switchrole.This is should improve accessibility because practically the
slide-toggleis neither always causing an immediately effective value change
(like a
button), nor does its value only become effective on formsubmission (like a
role="checkbox)Read more here: https://www.w3.org/TR/wai-aria-1.1/#switch. Similar to what mdc recommends.
Fixes #14949.