feat(drag-drop): add the ability to disable sorting in a list #15064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
14838/drag-drop-disable-sorting
branch
from
264a689 to
2865ac8
Compare
|
Thanks for implementing. When can we expect this feature to be merged? |
jelbourn
approved these changes
Feb 20, 2019
src/cdk/drag-drop/drop-list-ref.ts
Outdated
| const currentIndex = this._activeDraggables.indexOf(item); | ||
| const newPositionReference = this._activeDraggables[newIndex]; | ||
| // If sorting is disabled, we want the item to return to its starting | ||
| // position, if the user is returning it to its initial container. |
There was a problem hiding this comment.
nit: omit comma after "position"
jelbourn
added
pr: lgtm
action: merge
Adds the ability to disable sorting inside of a `CdkDropList`. This allows for use cases where one list is considered the source and one or more connected lists are the destinations, and the user isn't supposed to sort the items within the source list. Fixes angular#14838.
crisbeto
force-pushed
the
14838/drag-drop-disable-sorting
branch
from
2865ac8 to
9cb2afc
Compare
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 9, 2019
Documents the functionality from angular#15064 and adds a live example.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 9, 2019
Documents the functionality from angular#15064 and adds a live example.
mmalerba
pushed a commit
that referenced
this pull request
Mar 11, 2019
Documents the functionality from #15064 and adds a live example.
Suresh918
pushed a commit
to Suresh918/material2
that referenced
this pull request
Apr 15, 2019
…lar#15426) Documents the functionality from angular#15064 and adds a live example.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to disable sorting inside of a
CdkDropList. This allows for use cases where one list is considered the source and one or more connected lists are the destinations, and the user isn't supposed to sort the items within the source list.Fixes #14838.