Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: simplify api golden target names #14973

Conversation

devversion
Copy link
Member

In order to make it easier to test/update goldens, the Bazel targets are updated to the match the actual golden file paths.

This is useful because developers can then use terminal autocompletion to go to the desired golden file, and just need to add the _api suffix. This easier than manually constructing the Bazel API target name which is not intuitive and takes up time.

* In order to make it easier to test/update goldens, the Bazel targets are updated to the match the actual golden file paths. This is useful because developers can then use terminal autocompletion to go to the desired golden file, and just need to add the `_api` suffix. This easier than manually constructing the Bazel API target name which is not intuitive and takes up time.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Jan 27, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 27, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Side note: we should add a command to just say "approve all goldens", ideally only for stuff that has changed.

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 28, 2019
@devversion
Copy link
Member Author

devversion commented Jan 28, 2019

Yep that's a good idea. I already tried looking into this some weeks ago, but initially with "approving all goldens" it turned out to be difficult because bazel run cannot run multiple targets concurrently, so we would need to run sequentially which is pretty slow for all goldens.

I will have a look in only updating the changed goldens.

@mmalerba mmalerba merged commit ddd347d into angular:master Jan 29, 2019
mmalerba pushed a commit that referenced this pull request Feb 4, 2019
* In order to make it easier to test/update goldens, the Bazel targets are updated to the match the actual golden file paths. This is useful because developers can then use terminal autocompletion to go to the desired golden file, and just need to add the `_api` suffix. This easier than manually constructing the Bazel API target name which is not intuitive and takes up time.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants