Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update dev instructions for the repo #13890

Merged
merged 1 commit into from
Oct 31, 2018
Merged

docs: update dev instructions for the repo #13890

merged 1 commit into from
Oct 31, 2018

Conversation

jelbourn
Copy link
Member

No description provided.

@jelbourn jelbourn added docs This issue is related to documentation pr: merge safe target: patch This PR is targeted for the next patch release labels Oct 31, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 31, 2018
Splaktar
Splaktar approved these changes Oct 31, 2018
View reviewed changes
Copy link
Member

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar mentioned this pull request Oct 31, 2018
Closed
crisbeto
crisbeto approved these changes Oct 31, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 31, 2018
@jelbourn jelbourn merged commit 7c38fda into angular:master Oct 31, 2018
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
@jelbourn @atscott
docs: update dev instructions for the repo (angular#13890)
67f3c05
jelbourn added a commit that referenced this pull request Nov 6, 2018
@jelbourn
docs: update dev instructions for the repo (#13890)
b366cdf
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@Splaktar Splaktar Splaktar approved these changes

@josephperrott josephperrott Awaiting requested review from josephperrott

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jelbourn @Splaktar @crisbeto @googlebot