-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build(docs): fix description comments sometimes empty #12885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(docs): fix description comments sometimes empty #12885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
25d65f4
to
92a3713
Compare
@jelbourn Rebased. I'm adding |
@devversion travis is red across the board |
Seems to be because of See: https://unpkg.com/@angular-devkit/core@0.7.5/src/virtual-fs/host/test.d.ts |
5a95f12
to
a31f782
Compare
@jelbourn Fixed. For this PR, I'm just updating the package-lock to reflect the As mentioned in the comment above, previously I updated all packages and something broke. This is something that should be fixed separately. |
Follow-up commit for 4879dc4. --- Disables concatenation of multiple leading comments for a TypeScript node. Since all shipped source files have a license banner at top, the license banner comment would be incorrectly considered as "comment" for the first TypeScript node of a given file. Since there are various files in the Material project where the first node of a source file is exported and should only use the first leading comment, we need to disable comment concatenation. See for example: https://github.com/angular/material2/blob/master/src/cdk/coercion/boolean-property.ts
a31f782
to
d3cc38f
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Follow-up commit for 4879dc4 since angular/dgeni-packages#270 has been merged and published.
Disables concatenation of multiple leading comments for a TypeScript node. Since all shipped source files have a license banner at top, the license banner comment would be incorrectly considered as "comment" for the first TypeScript node of a given file. Since there are various files in the Material project where the first node of a source file is exported and should only use the first leading comment, we need to disable comment concatenation.
See for example: https://github.com/angular/material2/blob/master/src/cdk/coercion/boolean-property.ts