Skip to content

docs(dialog): emphasize clicking on backdrop in disableClose docs #11767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2018

Conversation

crisbeto
Copy link
Member

Mentions the backdrop explicitly in the disableClose docs in order to avoid confusion.

Fixes #11750.

Mentions the backdrop explicitly in the `disableClose` docs in order to avoid confusion.

Fixes angular#11750.
@crisbeto crisbeto requested a review from jelbourn as a code owner June 12, 2018 18:07
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 12, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed target: master only labels Jun 12, 2018
@jelbourn jelbourn merged commit 8be6d45 into angular:master Jun 12, 2018
@marc-wilson
Copy link

Is there a way to handle this a little bit better than updating the documentation? It still seems like a design flaw. It should operate just like MatSelect or MatMenu. There is no backdrop with those components but when a user clicks outside of it, it automatically closes. The MatDialog should have the same behavior if disableClose is used. Having a backdrop and disabling the ability to close the dialog serve two different use cases and shouldn't be dependent on each other. I understand there is a workaround by adding a custom backdropClass, but it's a workaround. disableClose and hasBackdrop are two different things and shouldn't be dependent on each other.

@jelbourn
Copy link
Member

It's a supported case to turn off the backdrop and let users interact with the page behind the dialog; it doesn't really have anything to do with disableClose at all.

@marc-wilson
Copy link

@jelbourn That is also a valid case which is why disableClose should work regardless of the value of hasBackdrop

victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
…1767)

Mentions the backdrop explicitly in the `disableClose` docs in order to avoid confusion.

Fixes #11750.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MatDialog - disableClose is dependent on hasBackdrop being true
4 participants