Skip to content

feat(stepper): allow number icon to be customized and expose template context variables - #10516

Merged
josephperrott merged 1 commit into
angular:masterfrom
crisbeto:10513/stepper-number-icon-customization
Mar 27, 2018
Merged

feat(stepper): allow number icon to be customized and expose template context variables#10516
josephperrott merged 1 commit into
angular:masterfrom
crisbeto:10513/stepper-number-icon-customization

Conversation

@crisbeto

Copy link
Copy Markdown
Member
  • Allows for the step number icon to be overwritten using matStepperIcon="number".
  • Exposes the index, active and optional template variables to matStepperIcon.

Fixes #10513.

@crisbeto
crisbeto requested a review from mmalerba as a code owner March 21, 2018 20:15
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 21, 2018
@mmalerba mmalerba added pr: lgtm target: minor This PR is targeted for the next minor release and removed pr: needs review labels Mar 22, 2018

/** Template context variables that are exposed to the `matStepperIcon` instances. */
_getIconContext() {
return {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should change the TemplateRef type parameter to reflect this

… context variables

* Allows for the step number icon to be overwritten using `matStepperIcon="number"`.
* Exposes the `index`, `active` and `optional` template variables to `matStepperIcon`.

Fixes angular#10513.
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 22, 2018
@crisbeto
crisbeto force-pushed the 10513/stepper-number-icon-customization branch from db4a09e to 0b44deb Compare March 22, 2018 18:30
@josephperrott
josephperrott merged commit 946fd84 into angular:master Mar 27, 2018
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stepper header without icons

4 participants