Skip to content

Screenshot Testing - Firebase Functions #3686

Closed

Description

Talked to @tinayuangao about PR #3628.

Things need to be done after the PR is merged:

  • Moving the setLocalFilenames method into the Firebase Functions
  • Separating Firebase functions into different JS files (clarity)
  • Setting Github Status from Firebase Functions (using firebase config)

Some additional things I would really like

  • Making the Firebase "routes" more like a REST API.
    e.g upload/screenshots/${PR_NUMBER}/images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    area: dev-infraIssue related to internal project infrastructurefeatureThis issue represents a new feature or feature request rather than a bug or bug fix

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions