Skip to content

feat(theming): Provide reasonable theme defaults if no themes are included #27840

Open

Description

Feature Description

I'm working on upgrading to version 15 and after running the migration and starting to investigate the changes required, I noticed that if you don't define a custom theme or import a default one, components' styles will be broken.

When I went with a default theme, I wanted to fix some structural strangeness like this:
image
Then I noticed that this and other structural styles (like paddings etc...) are defined in a theme file instead of being a part of the core.

Why? Aren't they supposed to be the same? Shouldn't theme be about color and typography?
Am I missing the density here? But even if so, why not have a default styles that can optionally be overwritten by applying a theme?

Use Case

Including (at least) structural styles into the core styles imo would make it clearer and easier to start using the library, since you wouldn't have to learn about the theming (you gotta admit, it's confusing). Also it feels less of a hack to overwrite library's CSS from one source than multiple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    area: themingfeatureThis issue represents a new feature or feature request rather than a bug or bug fixneeds: discussionFurther discussion with the team is needed before proceeding

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions