Skip to content

fix(schematics): require only exported devkit paths from the shipped schematics #3793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
armando-navarro merged 2 commits into from
Oct 9, 2026
Merged

fix(schematics): require only exported devkit paths from the shipped schematics #3793

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d88d4d6
fix(schematics): require only exported devkit paths from the shipped …
armando-navarro Oct 7, 2026
277ddfd
Merge branch 'main' into a68-schematics-tasks-import
armando-navarro Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 31 additions & 13 deletions tools/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,8 +384,24 @@ const schematicEntryPoints = [
['update', 'v21', 'index'],
];

const externalPackages = [
"@angular-devkit/schematics",
"@angular-devkit/architect",
"@angular-devkit/core",
"rxjs",
"@schematics/angular",
"jsonc-parser",
"firebase-tools",
"typescript"
];

/* Allowed package subpaths for bundles. Each must be in that package's `exports` map, or the
* schematics cannot load with any version of the package that has one. */
const exportedSubpaths = ['@angular-devkit/schematics/tasks', '@schematics/angular/utility', 'rxjs/operators'];
const isPackageSubpath = (path: string) => externalPackages.some(name => path.startsWith(`${name}/`));

async function compileSchematics() {
await esbuild.build({
const { metafile } = await esbuild.build({
entryPoints: schematicEntryPoints.map(segments => `${src('schematics', ...segments)}.ts`),
format: "cjs",
// turns out schematics don't support ESM, need to use webpack or shim these
Expand All @@ -396,20 +412,22 @@ async function compileSchematics() {
minify: true,
platform: "node",
target: "es2016",
external: [
"@angular-devkit/schematics",
"@angular-devkit/architect",
"@angular-devkit/core",
"rxjs",
"@schematics/angular",
"jsonc-parser",
"firebase-tools",
// The v21 migration parses user source with the TypeScript compiler; resolve it from
// the workspace at ng-update time instead of bundling ~3.5MB into the package.
"typescript"
],
external: externalPackages,
alias: { "@angular-devkit/schematics/tasks/index.js": "@angular-devkit/schematics/tasks" },
outdir: dest('schematics'),
metafile: true,
});
const importersBySubpath = new Map<string, string[]>();
for (const [importer, { imports }] of Object.entries(metafile.inputs)) {
for (const { path } of imports.filter(entry => entry.external && isPackageSubpath(entry.path))) {
importersBySubpath.set(path, [...(importersBySubpath.get(path) ?? []), importer]);
}
}
const unlistedSubpaths = [...importersBySubpath.keys()].filter(subpath => !exportedSubpaths.includes(subpath));
if (unlistedSubpaths.length) {
const required = unlistedSubpaths.map(subpath => `\n ${subpath}, imported by ${importersBySubpath.get(subpath)?.join(', ')}`);
throw new Error(`The schematics require package paths that exportedSubpaths does not list:${required.join('')}\nAdd an alias in compileSchematics to a path the package exports, or, if the exports map in the newest published version lists the path (npm view <package>@next exports), add it to exportedSubpaths.`);
}
await Promise.all([
copy(src('schematics', 'versions.json'), dest('schematics', 'versions.json')),
copy(src('schematics', 'builders.json'), dest('schematics', 'builders.json')),
Expand Down
Loading