-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Update messaging.md #2732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update messaging.md #2732
Conversation
I think we all love Angular and if there is an Angular-ish way of using service workers together with this great AngularFire package, it should be noted here. Initially I got really stuck figuring out workbox. While it is very powerfull, but also time consuming. So I recommend giving the reader a bit more comfort about the potential/opportunities using AngularFire.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good change
@jamesdaniels I see I made typos.. Sorry about that. You can correct directly or you want me to do a PR? What is most convenient for you... Two small typos:
Apologies again. |
No worries. Feel free to send a PR. |
I think we all love Angular and if there is an Angular-ish way of using service workers together with this great AngularFire package, it should be noted here. Initially I got really stuck figuring out workbox. While it is very powerfull, but also time consuming. So I recommend giving the reader a bit more comfort about the potential/opportunities using AngularFire.
Checklist
yarn install
,yarn test
run successfully? (yes/no; required)Description
Code sample