build: update to Angular & CLI 10.1.x and re-run migrations#2598
Merged
jamesdaniels merged 1 commit intoangular:masterfrom Sep 25, 2020
Merged
build: update to Angular & CLI 10.1.x and re-run migrations#2598jamesdaniels merged 1 commit intoangular:masterfrom
jamesdaniels merged 1 commit intoangular:masterfrom
Conversation
- run v10.1 CLI migrations for lib, sample, and test projects - removes Solution style tsconfig - updates tslint config - pin zone.js@0.10.2 because 0.10.3 causes test failures - install or correct missing peerDependencies - update a few other dependencies - remove references to e2e in sample workspace as there are no e2e tests - replace deprecated `async()` with `waitForAsync()` in tests - add tsconfig.server.json to list of files for linting - fix tests prompting to enable Angular CLI analytics
jamesdaniels
approved these changes
Sep 25, 2020
Member
jamesdaniels
left a comment
jamesdaniels
left a comment
There was a problem hiding this comment.
LGTM, thanks! Good catch on the remaining provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
yarn install,yarn testrun successfully? yesDescription
update to Angular & CLI 10.1.x and re-run migrations
zone.js@0.10.2because0.10.3causes test failuresasync()withwaitForAsync()in teststsconfig.server.jsonto list of files for lintingCode sample
N/A