feat(functions): Add options param to httpsCallable functions #2434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #2433 I don't see a good way to test it without a big refactoring, open to suggestions.
|
@NothingEverHappens maybe use emulator? |
jamesdaniels
requested changes
May 19, 2020
|
why wait. Without that change cloudFunctions are not usable. The limit of 60s to execute a cloud function when you know how slow firestore queries are, makes this impossible to use. At least increase that limit to the highest value possible and let the cloud function handle the timeout |
|
I really need this. Any idea on when this is going to be merged? |
|
Can we expect this in the near future? |
|
Angular is nothing but problems!
…On Wed, Apr 29, 2020, 10:43 AM NothingEverHappens ***@***.***> wrote:
see #2433 <#2433>
I don't see a good way to test it without a big refactoring, open to
suggestions.
------------------------------
You can view, comment on, or merge this pull request online at:
#2434
Commit Summary
- feat(functions): Add options param to httpsCallable functions
File Changes
- *M* src/functions/functions.ts
<https://github.com/angular/angularfire/pull/2434/files#diff-e7e0d8817dc489d9fb79a1433858d66d>
(7)
Patch Links:
- https://github.com/angular/angularfire/pull/2434.patch
- https://github.com/angular/angularfire/pull/2434.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2434>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABRRDUNJMLBXF6HIVHMLSTRPBRLHANCNFSM4MT5W2FQ>
.
|
mcarriere
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #2433
I don't see a good way to test it without a big refactoring, open to suggestions.