Skip to content

chore(release): Changelog #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2017
Merged

chore(release): Changelog #1018

merged 2 commits into from
Jun 2, 2017

Conversation

jamesdaniels
Copy link
Member

Checklist

Description

Changelog!

Code sample

See #996

@markgoho
Copy link
Contributor

markgoho commented Jun 2, 2017

Have we updated the docs to reflect the change in usage?

Nice, I see the added info about the breaking change!

CHANGELOG.md Outdated
<a name="4.0.0-rc.1"></a>
# [4.0.0-rc.1](https://github.com/angular/angularfire2/compare/4.0.0-rc.0...v4.0.0-rc.1) (2017-06-02)

* **rc:** Update to Firebase JS SDK 4.0 ([9642f5](https://github.com/angular/angularfire2/commit/9642f589ba73add6d49a5818a1109028f8c7729b)
Copy link
Contributor

@markgoho markgoho Jun 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a ) at the end of the line

@jamesdaniels jamesdaniels changed the title (chore): Changelog chore(release): Changelog Jun 2, 2017
@jamesdaniels
Copy link
Member Author

@markgoho we have a note on it in the v4 upgrade guide. We have a lot of changes coming soon with our documentation. We're prioritizing getting the upgrade out ASAP to reduce confusion, while the new docs bake.

@jamesdaniels
Copy link
Member Author

Thanks for thinking of the docs!

@jamesdaniels jamesdaniels merged commit 3f57a39 into angular:master Jun 2, 2017
@jamesdaniels jamesdaniels deleted the rc1 branch June 2, 2017 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants