Discussion: 5.2 release

[jamesdaniels]

Hey all, figured I'd open an issue which could serve as a catch all for the 5.2 release and any issues people are having with the beta.

Release Candidate 3 is the most current on @angular/fire@next. We're aiming to release the week of June 27th, roughly aligning with the Angular 8 release.

Feel free to chime in.

Changelog

AngularFire 5.2 introduces support for Angular 8 and version 6 of the Firebase SDK.

Bug Fixes

• firestore: Fix for builds targeting Node (#2079) (8a33826)
• storage: Typo in updateMetadata method (#2029) (6133296)
• messaging: Allow AngularFireMessaging to be included in a server build (#1938) (9b870a9)

Features

• performance: AngularFire Performance Monitoring (#2064) (2469e77)
• auth-guard: AngularFire Auth Guards (#2016) (e32164d)
• firestore: Added option to include document IDs on valueChanges() (#1976) (7108875)
• firestore: Support Firestore Collection Group Queries (#2066) (c34c0f3)
• functions: Allow configuration of Functions Emulator Origin (#2017) (d12b4c5)
• schematics: ng deploy schematic (#2046) (be0a1fb)
• firestore: path on AngularFirestoreCollection's .doc is optional (#1974) (c2354f8)

[Splaktar]

I'll give it a shot here soon. I'm just waiting on the next Material RC to be compatible with Angular rc.5 so that @angular/flex-layout will compile. I've already got the Perf module imported and will start doing some testing on that once everything is building happily, hopefully by tomorrow.

I'll try to take a look at ng deploy as well.

[jamesdaniels]

Cut 5.2.0-beta.5 and I think that's it from me for the week.

[jamesdaniels]

I lied, couldn't stay away from the computer 😛 After a couple more fixes I'm pretty happy with this, calling it 5.2.0-rc.1 cutting now.

[maximelefort]

Hi,
My ionic/angular project works like a charm with the 5.2.0-rc.1.
But when I want to import AngularFirePerformanceModule, I've got an issue.

Version info
Angular: ^7.2.15
Firebase: ^6.0.2
AngularFire: ^5.2.0-rc.1

Other (e.g. Ionic/Cordova, Node, browser, operating system):
Node: 10.15.3
OS: darwin x64

How to reproduce these conditions

• Add a runtime config (http.get('/app-config.json'))
• Init AngularFire with FirebaseOptionsToken
• Import AngularFirePerformanceModule

Steps to set up and reproduce

NgModule looks like:

@NgModule({
declarations: [
AppComponent
],
entryComponents: [
],
imports: [
BrowserModule,
BrowserAnimationsModule,
HttpClientModule,
AngularFireModule,
AngularFirePerformanceModule,
AngularFireAuthModule,
AngularFirestoreModule,
IonicModule.forRoot(),
IonicStorageModule.forRoot(),
AppRoutingModule,
CoreModule,
],
providers: [
{ provide: APP_INITIALIZER, useFactory: appInitialization, deps: [AppConfigService], multi: true },
{ provide: FirebaseOptionsToken, useFactory: initializeFirebase, deps: [AppConfigService] },
{ provide: RouteReuseStrategy, useClass: IonicRouteStrategy }
],
bootstrap: [
AppComponent
]
})
export class AppModule {}

Factories look like this :

export function appInitialization(appConfig: AppConfigService) {
return (): Promise => {
return appConfig.loadAppConfig();
};
}

export function initializeFirebase(appConfig: AppConfigService) {
return appConfig.getConfig();
}

Sample data and security rules
allow read, write on all document (dev mode)

Debug output
** Errors in the JavaScript console **

core.js:15724 ERROR Error: Uncaught (in promise): FirebaseError: [code=invalid-argument]: projectId must be a string in FirebaseApp.options
FirebaseError: projectId must be a string in FirebaseApp.options
at new FirestoreError (index.cjs.js:352)
at Function.push../node_modules/@firebase/firestore/dist/index.cjs.js.Firestore.databaseIdFromApp (index.cjs.js:20456)
at new Firestore (index.cjs.js:20321)
at Object.firestore (index.cjs.js:21732)
at FirebaseAppImpl.push../node_modules/@firebase/app/dist/index.cjs.js.FirebaseAppImpl._getService (index.cjs.js:185)
at FirebaseAppImpl.firebaseAppImpl. [as firestore] (index.cjs.js:389)
at firestore.js:39
at ZoneDelegate.push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke (zone.js:391)
at Zone.push../node_modules/zone.js/dist/zone.js.Zone.run (zone.js:150)
at NgZone.push../node_modules/@angular/core/fesm5/core.js.NgZone.runOutsideAngular (core.js:17258)
at resolvePromise (zone.js:831)
at resolvePromise (zone.js:788)
at zone.js:892
at ZoneDelegate.push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invokeTask (zone.js:423)
at Object.onInvokeTask (core.js:17290)
at ZoneDelegate.push../node_modules/zone.js/dist/zone.js.ZoneDelegate.invokeTask (zone.js:422)
at Zone.push../node_modules/zone.js/dist/zone.js.Zone.runTask (zone.js:195)
at drainMicroTaskQueue (zone.js:601)

** Output from firebase.database().enableLogging(true); **

** Screenshots **

Actual behavior
when I import AngularFirePerformanceModule it seems to initialize firebase earlier in the bootstrapping.
Configuration load and firebase initialization seem to be done in parallele.
That would explain why projectId is empty.

Expected behavior
Initialization should be done after the framework bootstrapping.

[jamesdaniels]

@maximelefort I've made initialization of AngularFirePerformance eager in AngularFirePerformanceModule so that collection of automatic traces still happen even if AngularFirePerformance isn't injected into any modules... I could also provide a non-eager NgModule.

Another way to do this would be for you to provide FirebaseApp or AngularFirePerformance yourself, dependent on your AppConfigService. See the implementations here and here. I've been meaning to make use of custom providers a bit cleaner / better documented.

Thoughts?