Skip to content

Conversation

@alexeagle
Copy link
Contributor

This is no longer needed for g3sync. Also, it frees up a travis worker.

@alexeagle alexeagle added action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes and removed cla: yes labels Jan 3, 2016
@IgorMinar
Copy link
Contributor

The build only job is also used for payload size analytics and continuous delivery to npm and pub.

Can you keep it and just remove the upload to gcs?

@IgorMinar IgorMinar added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 3, 2016
@IgorMinar IgorMinar assigned alexeagle and unassigned IgorMinar Jan 3, 2016
@alexeagle alexeagle added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 4, 2016
@alexeagle alexeagle assigned IgorMinar and unassigned alexeagle Jan 4, 2016
@alexeagle alexeagle added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 4, 2016
@alexeagle
Copy link
Contributor Author

Sure, done.
It still seems like we ought to be able to save a travis worker. We already do these build steps in other builds. A small change in publish-build-artifacts.sh seems sufficient. Is that worth doing?

@IgorMinar
Copy link
Contributor

discussed offline... let's move the work to other works in a new PR.

Can you also create an issue to audit our CI jobs and document what's
running where in a similar fashion as we document our bundles:
https://github.com/angular/angular/blob/d116861c8e884d911f15b8caabeefc6f049c775d/modules/angular2/docs/bundles/overview.md#es5-and-ngupgrade-users
or
maybe even create a DSL for job splitup similar to how we will soon test
angular on various browsers:
https://github.com/angular/angular/pull/5795/files#diff-6c156334b18015a66bc1bb55cedd6838R5

On Mon, Jan 4, 2016 at 9:28 AM Alex Eagle notifications@github.com wrote:

Sure, done.
It still seems like we ought to be able to save a travis worker. We
already do these build steps in other builds. A small change in
publish-build-artifacts.sh seems sufficient. Is that worth doing?


Reply to this email directly or view it on GitHub
#6232 (comment).

@alexeagle
Copy link
Contributor Author

filed #6256 for the follow-up

@alexeagle alexeagle force-pushed the travis_cleanup branch 2 times, most recently from 14de4fc to 4859277 Compare January 4, 2016 21:25
This is no longer needed for g3sync.
@alexeagle
Copy link
Contributor Author

ready to merge

@mary-poppins
Copy link

Merging PR #6232 on behalf of @alxhub to branch presubmit-alxhub-pr-6232.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants