-
Notifications
You must be signed in to change notification settings - Fork 25.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(docs-infra): add support for block syntax to dgeni #52123
Conversation
Deployed aio for c8776e4 to: https://ng-dev-previews-fw--pr-angular-angular-52123-aio-7hz5zo9f.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but it will need cleanup to add new doc entries to the pullapprove config (currently the lint job is failing)
This adds the new block syntax to dgeni docs pipeline, mainly copying the way that elements (`<ng-content>` etc.) work. Actual doc content is just a placeholder for this PR.
3a0edb2
to
c8776e4
Compare
This PR was merged into the repository by commit a49ee46. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This adds the new block syntax to dgeni docs pipeline, mainly copying the way that elements (`<ng-content>` etc.) work. Actual doc content is just a placeholder for this PR. PR Close angular#52123
This adds the new block syntax to dgeni docs pipeline, mainly copying the way that elements (
<ng-content>
etc.) work. Actual doc content is just a placeholder for this PR.