Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(docs-infra): add support for block syntax to dgeni #52123

Closed
wants to merge 1 commit into from

Conversation

jelbourn
Copy link
Member

This adds the new block syntax to dgeni docs pipeline, mainly copying the way that elements (<ng-content> etc.) work. Actual doc content is just a placeholder for this PR.

@jelbourn jelbourn added area: docs-infra target: minor This PR is targeted for the next minor release labels Oct 10, 2023
@ngbot ngbot bot modified the milestone: Backlog Oct 10, 2023
@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Deployed aio for c8776e4 to: https://ng-dev-previews-fw--pr-angular-angular-52123-aio-7hz5zo9f.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it will need cleanup to add new doc entries to the pullapprove config (currently the lint job is failing)

@pkozlowski-opensource pkozlowski-opensource added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Oct 10, 2023
This adds the new block syntax to dgeni docs pipeline, mainly copying
the way that elements (`<ng-content>` etc.) work. Actual doc content is
just a placeholder for this PR.
@jelbourn jelbourn force-pushed the block-api-docs-dgeni branch from 3a0edb2 to c8776e4 Compare October 10, 2023 18:08
@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 10, 2023
@angular-robot
Copy link
Contributor

angular-robot bot commented Oct 10, 2023

This PR was merged into the repository by commit a49ee46.

@angular-robot angular-robot bot closed this in a49ee46 Oct 10, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
This adds the new block syntax to dgeni docs pipeline, mainly copying
the way that elements (`<ng-content>` etc.) work. Actual doc content is
just a placeholder for this PR.

PR Close angular#52123
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants