Skip to content

refactor(core): minor updates to TestBed error messages #50072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor(core): minor updates to TestBed error messages #50072

wants to merge 1 commit into from

Conversation

AndrewKushnir
Copy link
Contributor

This commit updates TestBed error messages to avoid using R3TestBed reference and just use TestBed instead.

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir
refactor(core): minor updates to TestBed error messages
4f99d8f 
This commit updates TestBed error messages to avoid using `R3TestBed` reference and just use `TestBed` instead.
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate labels Apr 28, 2023
@ngbot ngbot bot modified the milestone: Backlog Apr 28, 2023
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 1, 2023
@AndrewKushnir AndrewKushnir added the action: presubmit The PR is in need of a google3 presubmit label May 1, 2023
@AndrewKushnir
Copy link
Contributor Author

Presubmit.

@AndrewKushnir AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label May 1, 2023
@AndrewKushnir
Copy link
Contributor Author

Caretaker note: presubmit is "green".

@pkozlowski-opensource pkozlowski-opensource added target: patch This PR is targeted for the next patch release and removed target: rc This PR is targeted for the next release-candidate labels May 4, 2023
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 2180a69.

pkozlowski-opensource pushed a commit that referenced this pull request May 4, 2023
@AndrewKushnir @pkozlowski-opensource
refactor(core): minor updates to TestBed error messages (#50072)
431b922 
This commit updates TestBed error messages to avoid using `R3TestBed` reference and just use `TestBed` instead.

PR Close #50072
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewKushnir @pkozlowski-opensource @jessicajaniuk