Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: watch for sauce service failures when waiting for it to start #36109

Closed
wants to merge 2 commits into from
Closed

build: watch for sauce service failures when waiting for it to start #36109

wants to merge 2 commits into from

Conversation

gregmagolan
Copy link
Contributor

@gregmagolan gregmagolan commented Mar 17, 2020 •
edited
Loading

Also build: fix saucelabs jobs that were broken by bazelisk change.

Also add two targets to make it more convenient to tail & dump the sauce service logs: //tools/saucelabs:sauce_service_tail & //tools/saucelabs:sauce_service_log

@kara This will fix the issue you ran into when you were using the wrong sc binary :)

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@gregmagolan gregmagolan added target: patch This PR is targeted for the next patch release area: build & ci Related the build and CI infrastructure of the project labels Mar 17, 2020
@ngbot ngbot bot added this to the needsTriage milestone Mar 17, 2020
gregmagolan added a commit to gregmagolan/angular that referenced this pull request Mar 17, 2020
@gregmagolan
build: ci for angular#36109 [DO NOT MERGE]
e958aaf
@gregmagolan gregmagolan mentioned this pull request Mar 17, 2020
Closed
@gregmagolan
Copy link
Contributor Author

Saucelabs jobs are normally monitor only so CI is turned on here: #36111

josephperrott
josephperrott approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tools/saucelabs/sauce-service.sh Show resolved Hide resolved
@gregmagolan
build: watch for sauce service failures when waiting for it to start
cd58da2 
Also add two targets to make it more convienent to tail & dump the sauce service logs: //tools/saucelabs:sauce_service_tail & //tools/saucelabs:sauce_service_log
@gregmagolan gregmagolan force-pushed the sauce_service_fixes branch from e5f11c1 to cd58da2 Compare March 17, 2020 16:58
@gregmagolan gregmagolan added the action: merge The PR is ready for merge by the caretaker label Mar 17, 2020
gregmagolan added a commit to gregmagolan/angular that referenced this pull request Mar 17, 2020
@gregmagolan
build: ci for angular#36109 [DO NOT MERGE]
151a277
@gregmagolan gregmagolan added state: blocked and removed action: merge The PR is ready for merge by the caretaker labels Mar 17, 2020
@gregmagolan
Copy link
Contributor Author

gregmagolan commented Mar 17, 2020 •
edited
Loading

Waiting on green #36111

josephperrott
josephperrott approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregmagolan gregmagolan added action: merge The PR is ready for merge by the caretaker and removed state: blocked labels Mar 17, 2020
AndrewKushnir pushed a commit that referenced this pull request Mar 17, 2020
@gregmagolan @AndrewKushnir
build: fix saucelabs jobs that were broken by bazelisk change (#36109)
a1cae28 
PR Close #36109
AndrewKushnir pushed a commit that referenced this pull request Mar 17, 2020
@gregmagolan @AndrewKushnir
build: watch for sauce service failures when waiting for it to start (#…
f1ed672 
…36109)

Also add two targets to make it more convienent to tail & dump the sauce service logs: //tools/saucelabs:sauce_service_tail & //tools/saucelabs:sauce_service_log

PR Close #36109
AndrewKushnir pushed a commit that referenced this pull request Mar 17, 2020
@gregmagolan @AndrewKushnir
build: fix saucelabs jobs that were broken by bazelisk change (#36109)
48fa89f 
PR Close #36109
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.
3 participants
@gregmagolan @josephperrott @googlebot