Skip to content

Conversation

jbogarthyde
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Previous TOH PR changed page titles, but missed TOC (left-nav) titles
https://angular.io/tutorial/toh-pt3
https://angular.io/tutorial/toh-pt4

Issue Number: N/A

What is the new behavior?

TOC titles match, slight update of titles

Does this PR introduce a breaking change?

  • Yes
  • No

@jbogarthyde jbogarthyde self-assigned this Feb 3, 2020
@ngbot ngbot bot added this to the Backlog milestone Feb 3, 2020
@mary-poppins
Copy link

You can preview 9e00729 at https://pr35126-9e00729.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 80457f6 at https://pr35126-80457f6.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 38bf4fc at https://pr35126-38bf4fc.ngbuilds.io/.

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@mary-poppins
Copy link

You can preview d3312c0 at https://pr35126-d3312c0.ngbuilds.io/.

@jbogarthyde jbogarthyde added the action: merge The PR is ready for merge by the caretaker label Feb 10, 2020
@jbogarthyde jbogarthyde removed the request for review from aikithoughts February 10, 2020 21:20
@kara kara closed this in dcb8d67 Feb 11, 2020
kara pushed a commit that referenced this pull request Feb 11, 2020
@jbogarthyde jbogarthyde deleted the jb-toh-toc branch February 17, 2020 18:25
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours freq1: low risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants