-
Notifications
You must be signed in to change notification settings - Fork 26.3k
aio: Update getting started deployment instructions #30465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
6b1e2f4
to
eb6a6fc
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
You can preview ff49016 at https://pr30465-ff49016.ngbuilds.io/. |
You can preview eb6a6fc at https://pr30465-eb6a6fc.ngbuilds.io/. |
eb6a6fc
to
c20d714
Compare
You can preview c20d714 at https://pr30465-c20d714.ngbuilds.io/. |
Caretaker note: Codefresh build failure is unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I posted some details about how to improve this and include a production deployment after talking to the Stackblitz team at ng-conf. You can find those details in #docs on Slack.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
NOTE!
This is intended to be merged after #29651 is updated and merged.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?