Skip to content

aio: Update getting started deployment instructions #30465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

StephenFluin
Copy link
Contributor

NOTE!
This is intended to be merged after #29651 is updated and merged.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

@StephenFluin StephenFluin requested a review from jenniferfell May 14, 2019 22:01
@StephenFluin StephenFluin requested review from IgorMinar and a team as code owners May 14, 2019 22:01
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@ngbot ngbot bot added this to the needsTriage milestone May 15, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog May 17, 2019
@kapunahelewong kapunahelewong added the target: patch This PR is targeted for the next patch release label May 17, 2019
@StephenFluin StephenFluin force-pushed the jfell-getting-started-ia branch 2 times, most recently from 6b1e2f4 to eb6a6fc Compare May 21, 2019 18:24
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@mary-poppins
Copy link

You can preview ff49016 at https://pr30465-ff49016.ngbuilds.io/.
You can preview 6b1e2f4 at https://pr30465-6b1e2f4.ngbuilds.io/.

@brandonroberts brandonroberts modified the milestones: Backlog, version 8 May 21, 2019
@mary-poppins
Copy link

You can preview eb6a6fc at https://pr30465-eb6a6fc.ngbuilds.io/.

@StephenFluin StephenFluin force-pushed the jfell-getting-started-ia branch from eb6a6fc to c20d714 Compare May 21, 2019 20:14
@IgorMinar IgorMinar dismissed brandonroberts’s stale review May 21, 2019 20:23

feedback addressed

@IgorMinar IgorMinar removed the request for review from jenniferfell May 21, 2019 20:24
@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label May 21, 2019
@mary-poppins
Copy link

You can preview c20d714 at https://pr30465-c20d714.ngbuilds.io/.

@IgorMinar IgorMinar added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 21, 2019
@brandonroberts
Copy link
Contributor

Caretaker note: Codefresh build failure is unrelated.

Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I posted some details about how to improve this and include a production deployment after talking to the Stackblitz team at ng-conf. You can find those details in #docs on Slack.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort3: weeks merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note risk: medium target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants