ci: cleanup ivy bazel tags #26735

IgorMinar · 2018-10-25T01:18:25Z

we no longer need to rewrite the tags on the fly and can now rely on blacklisting via explicit tags set on individual targets.

this change revealed that we were not running certain tests on CI which have always been broken or got broken just recently. especially the hello world symbol test fix is concerning because it highlights a size regression that we need to investigate.

googlebot · 2018-10-25T01:18:27Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

googlebot · 2018-10-25T01:18:39Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

mary-poppins · 2018-10-25T01:21:53Z

You can preview 640f655 at https://pr26735-640f655.ngbuilds.io/.

googlebot · 2018-10-25T05:29:21Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

mary-poppins · 2018-10-25T05:33:31Z

You can preview f5d353f at https://pr26735-f5d353f.ngbuilds.io/.

mary-poppins · 2018-10-25T06:06:38Z

You can preview d7901b1 at https://pr26735-d7901b1.ngbuilds.io/.

mary-poppins · 2018-10-25T06:29:32Z

You can preview 4f0f6d0 at https://pr26735-4f0f6d0.ngbuilds.io/.

mary-poppins · 2018-10-25T06:46:18Z

You can preview 4c44d98 at https://pr26735-4c44d98.ngbuilds.io/.

mary-poppins · 2018-10-25T06:47:57Z

You can preview 18dbd96 at https://pr26735-18dbd96.ngbuilds.io/.

mary-poppins · 2018-10-25T07:07:24Z

You can preview 3d0c749 at https://pr26735-3d0c749.ngbuilds.io/.

mary-poppins · 2018-10-25T07:09:58Z

You can preview 1846935 at https://pr26735-1846935.ngbuilds.io/.

mary-poppins · 2018-10-25T07:42:27Z

You can preview aa2e09c at https://pr26735-aa2e09c.ngbuilds.io/.

mary-poppins · 2018-10-25T19:44:33Z

You can preview 318ba67 at https://pr26735-318ba67.ngbuilds.io/.

With bazel-contrib/rules_nodejs#388 fixed we can stop messing around with tags and just rely on the explicitly defined tags. PR Close angular#26735

These tests were previously not running on CI so they have always been broken, or got broken just recently :-(. test(ivy): mark failing test targets with fixme-ivy-jit and fixme-ivy-local tags PR Close angular#26735

…ntal variable (angular#26735) PR Close angular#26735

This means that we use the same command to run test on CI as when developing locally. PR Close angular#26735

…ivy-* tags (angular#26735) This target fails with odd error that we need to investigate: [01:19:32] I/direct - Using ChromeDriver directly... [01:19:32] E/direct - Error code: 135 [01:19:32] E/direct - Error message: Could not find chromedriver at /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/ngdeps/node_modules/webdriver-manager/selenium/chromedriver_2.41. Run 'webdriver-manager update' to download binaries. [01:19:32] E/direct - Error: Could not find chromedriver at /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/ngdeps/node_modules/webdriver-manager/selenium/chromedriver_2.41. Run 'webdriver-manager update' to download binaries. PR Close angular#26735

so that they are more suitable for CI usage. PR Close angular#26735

…26788) PR Close #26735 PR Close #26788

…6788) With bazel-contrib/rules_nodejs#388 fixed we can stop messing around with tags and just rely on the explicitly defined tags. PR Close #26735 PR Close #26788

These tests were previously not running on CI so they have always been broken, or got broken just recently :-(. test(ivy): mark failing test targets with fixme-ivy-jit and fixme-ivy-local tags PR Close #26735 PR Close #26788

…ntal variable (#26735) (#26788) PR Close #26735 PR Close #26788

This means that we use the same command to run test on CI as when developing locally. PR Close #26735 PR Close #26788

…ivy-* tags (#26735) (#26788) This target fails with odd error that we need to investigate: [01:19:32] I/direct - Using ChromeDriver directly... [01:19:32] E/direct - Error code: 135 [01:19:32] E/direct - Error message: Could not find chromedriver at /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/ngdeps/node_modules/webdriver-manager/selenium/chromedriver_2.41. Run 'webdriver-manager update' to download binaries. [01:19:32] E/direct - Error: Could not find chromedriver at /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/ngdeps/node_modules/webdriver-manager/selenium/chromedriver_2.41. Run 'webdriver-manager update' to download binaries. PR Close #26735 PR Close #26788

so that they are more suitable for CI usage. PR Close #26735 PR Close #26788

…6735) PR Close angular#26735

With bazel-contrib/rules_nodejs#388 fixed we can stop messing around with tags and just rely on the explicitly defined tags. PR Close angular#26735

These tests were previously not running on CI so they have always been broken, or got broken just recently :-(. test(ivy): mark failing test targets with fixme-ivy-jit and fixme-ivy-local tags PR Close angular#26735

…ntal variable (angular#26735) PR Close angular#26735

This means that we use the same command to run test on CI as when developing locally. PR Close angular#26735

…ivy-* tags (angular#26735) This target fails with odd error that we need to investigate: [01:19:32] I/direct - Using ChromeDriver directly... [01:19:32] E/direct - Error code: 135 [01:19:32] E/direct - Error message: Could not find chromedriver at /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/ngdeps/node_modules/webdriver-manager/selenium/chromedriver_2.41. Run 'webdriver-manager update' to download binaries. [01:19:32] E/direct - Error: Could not find chromedriver at /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/ngdeps/node_modules/webdriver-manager/selenium/chromedriver_2.41. Run 'webdriver-manager update' to download binaries. PR Close angular#26735

so that they are more suitable for CI usage. PR Close angular#26735

…6735) PR Close angular#26735

With bazel-contrib/rules_nodejs#388 fixed we can stop messing around with tags and just rely on the explicitly defined tags. PR Close angular#26735

These tests were previously not running on CI so they have always been broken, or got broken just recently :-(. test(ivy): mark failing test targets with fixme-ivy-jit and fixme-ivy-local tags PR Close angular#26735

…ntal variable (angular#26735) PR Close angular#26735

This means that we use the same command to run test on CI as when developing locally. PR Close angular#26735

…ivy-* tags (angular#26735) This target fails with odd error that we need to investigate: [01:19:32] I/direct - Using ChromeDriver directly... [01:19:32] E/direct - Error code: 135 [01:19:32] E/direct - Error message: Could not find chromedriver at /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/ngdeps/node_modules/webdriver-manager/selenium/chromedriver_2.41. Run 'webdriver-manager update' to download binaries. [01:19:32] E/direct - Error: Could not find chromedriver at /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/ngdeps/node_modules/webdriver-manager/selenium/chromedriver_2.41. Run 'webdriver-manager update' to download binaries. PR Close angular#26735

so that they are more suitable for CI usage. PR Close angular#26735

angular-automatic-lock-bot · 2019-09-14T05:53:25Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: no label Oct 25, 2018

IgorMinar added the cla: yes label Oct 25, 2018

googlebot removed the cla: no label Oct 25, 2018

IgorMinar added area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release labels Oct 25, 2018

ngbot bot added this to the needsTriage milestone Oct 25, 2018

googlebot added cla: no and removed cla: yes labels Oct 25, 2018

IgorMinar mentioned this pull request Oct 25, 2018

docs: rename ivy compile mode 'local' to 'aot' in BAZEL.md #26724

Closed

2 tasks

IgorMinar force-pushed the ci/cleanup-ivy-bazel-tags branch 3 times, most recently from 9c0db65 to 4f0f6d0 Compare October 25, 2018 06:25

IgorMinar force-pushed the ci/cleanup-ivy-bazel-tags branch from 0e9e707 to 4c44d98 Compare October 25, 2018 06:42

IgorMinar force-pushed the ci/cleanup-ivy-bazel-tags branch 2 times, most recently from 34eae68 to 1846935 Compare October 25, 2018 07:05

IgorMinar changed the title ~~Ci/cleanup ivy bazel tags~~ ci: cleanup ivy bazel tags Oct 25, 2018

docs: rename ivy compile mode 'local' to 'aot' in BAZEL.md

9d42367

mhevery pushed a commit to mhevery/angular that referenced this pull request Oct 26, 2018

build: fix symbol-extractor by passing through "compile" as environme…

d2ce351

…ntal variable (angular#26735) PR Close angular#26735

mhevery pushed a commit to mhevery/angular that referenced this pull request Oct 26, 2018

ci: use yarn test-ivy-... (angular#26735)

1674087

This means that we use the same command to run test on CI as when developing locally. PR Close angular#26735

mhevery pushed a commit to mhevery/angular that referenced this pull request Oct 26, 2018

ci: configure chrome options for protractor (angular#26735)

0d5e901

so that they are more suitable for CI usage. PR Close angular#26735

mhevery added a commit to mhevery/angular that referenced this pull request Oct 26, 2018

fixup! test(ivy): fix or disable failing ivy tests (angular#26735)

7d81bd6

matsko pushed a commit that referenced this pull request Oct 26, 2018

docs: rename ivy compile mode 'local' to 'aot' in BAZEL.md (#26735) (#…

2f3308e

…26788) PR Close #26735 PR Close #26788

matsko pushed a commit that referenced this pull request Oct 26, 2018

build: fix symbol-extractor by passing through "compile" as environme…

00e6569

…ntal variable (#26735) (#26788) PR Close #26735 PR Close #26788

matsko pushed a commit that referenced this pull request Oct 26, 2018

ci: use yarn test-ivy-... (#26735) (#26788)

046c96a

This means that we use the same command to run test on CI as when developing locally. PR Close #26735 PR Close #26788

matsko pushed a commit that referenced this pull request Oct 26, 2018

ci: configure chrome options for protractor (#26735) (#26788)

71580c8

so that they are more suitable for CI usage. PR Close #26735 PR Close #26788

sculove pushed a commit to sculove/angular that referenced this pull request Nov 2, 2018

docs: rename ivy compile mode 'local' to 'aot' in BAZEL.md (angular#2…

16f7d7b

…6735) PR Close angular#26735

sculove pushed a commit to sculove/angular that referenced this pull request Nov 2, 2018

build: fix symbol-extractor by passing through "compile" as environme…

6c939c3

…ntal variable (angular#26735) PR Close angular#26735

sculove pushed a commit to sculove/angular that referenced this pull request Nov 2, 2018

ci: use yarn test-ivy-... (angular#26735)

0b03e25

This means that we use the same command to run test on CI as when developing locally. PR Close angular#26735

sculove pushed a commit to sculove/angular that referenced this pull request Nov 2, 2018

ci: configure chrome options for protractor (angular#26735)

f49df54

so that they are more suitable for CI usage. PR Close angular#26735

FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019

docs: rename ivy compile mode 'local' to 'aot' in BAZEL.md (angular#2…

a287bd7

…6735) PR Close angular#26735

FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019

build: fix symbol-extractor by passing through "compile" as environme…

8082ea7

…ntal variable (angular#26735) PR Close angular#26735

FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019

ci: use yarn test-ivy-... (angular#26735)

cac40f3

This means that we use the same command to run test on CI as when developing locally. PR Close angular#26735

FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019

ci: configure chrome options for protractor (angular#26735)

6a968e9

so that they are more suitable for CI usage. PR Close angular#26735

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: cleanup ivy bazel tags #26735

ci: cleanup ivy bazel tags #26735

IgorMinar commented Oct 25, 2018 •

edited

Loading

googlebot commented Oct 25, 2018

googlebot commented Oct 25, 2018

mary-poppins commented Oct 25, 2018

googlebot commented Oct 25, 2018

mary-poppins commented Oct 25, 2018

mary-poppins commented Oct 25, 2018

mary-poppins commented Oct 25, 2018

mary-poppins commented Oct 25, 2018

mary-poppins commented Oct 25, 2018

mary-poppins commented Oct 25, 2018

mary-poppins commented Oct 25, 2018

mary-poppins commented Oct 25, 2018

mary-poppins commented Oct 25, 2018

angular-automatic-lock-bot bot commented Sep 14, 2019

ci: cleanup ivy bazel tags #26735

ci: cleanup ivy bazel tags #26735

Conversation

IgorMinar commented Oct 25, 2018 • edited Loading

googlebot commented Oct 25, 2018

googlebot commented Oct 25, 2018

mary-poppins commented Oct 25, 2018

googlebot commented Oct 25, 2018

mary-poppins commented Oct 25, 2018

mary-poppins commented Oct 25, 2018

mary-poppins commented Oct 25, 2018

mary-poppins commented Oct 25, 2018

mary-poppins commented Oct 25, 2018

mary-poppins commented Oct 25, 2018

mary-poppins commented Oct 25, 2018

mary-poppins commented Oct 25, 2018

mary-poppins commented Oct 25, 2018

angular-automatic-lock-bot bot commented Sep 14, 2019

IgorMinar commented Oct 25, 2018 •

edited

Loading