refactor(i18n): extract Extractor from extract_i18n #12417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
reviewed
Oct 20, 2016
Contributor
There was a problem hiding this comment.
this seems like the place where we should canonicalize the path
Contributor
Author
There was a problem hiding this comment.
Doesn't seem to do it. Let's punt and fix this up in a more general PR.
I put an extractor into your extract so you can extract while you extract. This allows integrators to call Extractor as a library. Also refactors Extractor a bit so that callers need fewer arguments or arguments that are at the right semantic level. The refactoring causes no function change.
Contributor
Author
|
Test failure is a flake. |
IgorMinar
added
action: merge
Contributor
|
caretaker note: this pr causes breakages in g3 - @mprobst is working on an internal patch |
Contributor
|
unblocked. CI is red because of the DDOS attack that is still affecting saucelabs, I've seen the job be green in the previous run, so I'm going ahead and merging this. |
IgorMinar
pushed a commit
that referenced
this pull request
Oct 27, 2016
I put an extractor into your extract so you can extract while you extract. This allows integrators to call Extractor as a library. Also refactors Extractor a bit so that callers need fewer arguments or arguments that are at the right semantic level. The refactoring causes no function change.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put an extractor into your extract so you can extract while you
extract.
This allows integrators to call Extractor as a library. Also refactors
Extractor a bit so that callers need fewer arguments or arguments that
are at the right semantic level.
The refactoring causes no function change.