Angular v5 compiler rewrites imports

[Eddman]

I'm submitting a...

[x] Regression (a behavior that used to work and stopped working in a new release)

Current behavior

I'm using TypeScript paths to define a sub-module in my repo:

{
    "compilerOptions": {
        "baseUrl": ".",
        "rootDir": ".",
        "paths": {
            "@my-org/my-sub-module": [
                "./src/my-sub-module/public_api.ts"
            ]
        }
    }
}

Then in a .ts file I use the import:

import {some_class} from '@my-org/my-sub-module';

When I compile using NGC it resolves the imports correctly, but sometimes replaces it with relative path in the output files:

import { some_class } from "./../my-sub-module/public_api";

This is fine for base usage, but once I try to use rollup to bundle packages based on the paths it will try to include files that do not belong to my sub-module. The roots in paths are passed into external option of rollup. But these do not match the rewritten paths anymore...

The code was working fine in Angular 4.3.x.

Expected behavior

The imports are never replaced with relative paths.

Minimal reproduction of the problem with instructions

Can't find any pattern for which the imports are modified. It seems to be that they are changed once the relative path is shorter then the name in paths(?)...

Environment

Angular version: 5.0.0-beta.6
TypeScript: 2.3.4

[Toxicable]

v5 is currently in beta, the Compiler changes are not done yet.
I'd suggest waiting till RC at least before trying to use it

[tbosch]

This is probably related to tsickle trying to find the main imported file. However, this is no longer needed, so we can just flip the flag to false here: https://github.com/angular/angular/blob/master/packages/compiler-cli/src/main.ts#L49

@Toxicable would you have a bit of time to try this, if that fixes this problem?

Same problem seems to be in #17171

[Toxicable]

@tbosch sure I can take a look

[Toxicable]

@tbosch I attempted to reproduce this on v5.0.0-beta.7 but was unable to. I made this repo to show what I was trying: https://github.com/Toxicable/angular-indexmodule-issue
and as you can see in the dist it produced normal imports
https://github.com/Toxicable/angular-indexmodule-issue/blob/master/dist/main.js
The libs you see there are some of the ones people were having issues with in #17171

@Eddman Could you make us a minimal reproduction? maybe there is something slightly different in our tsconfig.json

[Toxicable]

@tbosch Ok I've manged to reproduce this, turns out I wasn't using "annotateForClosureCompiler": true in my tsconfig before, totally forgot about that :/
Anyway so I have this: https://github.com/Toxicable/angular-indexmodule-issue
which produces the below results

v5.0.0-beta.7

input

"paths": {
  "submodule": ["./my-module"]
},

//root main.ts
import { name } from 'submodule'

output

import { name } from "./my-module/index";

with convertIndexImportShorthand: false

import { name } from "submodule";

v4.4.3

That same code makes the output, but then throws an error

import { name } from 'submodule/index';

but if we instead use
input

import { UIRouterModule} from '@uirouter/angular';

output

import { UIRouterModule } from '@uirouter/angular/index';

and with convertIndexImportShorthand: false

import { UIRouterModule } from '@uirouter/angular';

[Kamilius]

@Toxicable could you specify where exactly this convertIndexImportShorthand: false should be specified to fix an issue for v4.4.3?

[Toxicable]

@Kamilius That's done by changing code in Angular itself since it's an internal setting for tsickle

[Kamilius]

@Toxicable got it. When approximately we can get this fix?

[Toxicable]

@Kamilius I'm not certain, a decision needs to be made if convertIndexImportShorthand is indeed going to be switched to false, I can't make this decision

[zhangyulins]

td 发自网易邮箱大师 On 09/22/2017 18:32, Fabian Wiles wrote: @Kamilius That's done by changing code in Angular itself since it's an internal setting for tsickle — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[Kamilius]

@Toxicable maybe you are aware, if there is a version that doesn't have this bug? Or maybe a workaround?