This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat(rootScope): stopImmediatePropagation method #4337
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…diate termination of all listeners
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
CLA signed. Real name: Simon Tsvilik |
added 2 commits
October 21, 2013 21:40
…oveClass/JQLiteHasClass by using element.classList property (where available). Improved original code through simple, pre-compiled RegExp. Improved code for minification by replacing commonly used strings with variables.
|
Ignoring the bogus commits in the PR, this looks like a cute feature, but I don't see how angular apps would benefit form it maybe except for some really obscure corner-cases. In general we discourage the use of scope events unless absolutely necessary. In most cases using data-binding is a better solution. For this reason I'm not going to merge this PR because it would be just extra fat and might encourage people to use scope events more. I appreciate your effort though. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding stopImmediatePropagation method to allow stopping of all immediate listeners on the scope. This is similar in behavior to jQuery's stopImmediatePropagation. Decision to put it together came out of this thread - #3564 (comment). Issue #3564