This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(docs-app): remove document.write() from docs index.html
#17035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the docs app used `document.write()`, causing the following warning on Chrome: ``` A parser-blocking, cross site (i.e. different eTLD+1) script, https://ajax.googleapis.com/ajax/libs/angularjs/1.7.9/angular.min.js, is invoked via document.write. The network request for this script MAY be blocked by the browser in this or a future page load due to poor network connectivity. ``` In the past, `document.write()` seems to have been used in order for browsers (such as Firefox) to work correctly with our dynamically set `<base>` tag and relative style/script URLs. This commit replaces `document.write()` with regular `<style>`/`<script>` tabs to avoid the warning (and potential issues due to poor network connectivity). It seems that the latest versions of Chrome, Firefox and IE can handle this fine (without naticeable delays). Fixes angular#15396
mgol
approved these changes
May 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the docs app used
document.write(), causing the following warning on Chrome:In the past,
document.write()seems to have been used in order for browsers (such as Firefox) to work correctly with our dynamically set<base>tag and relative style/script URLs.This commit replaces
document.write()with regular<style>/<script>tabs to avoid the warning (and potential issues due to poor network connectivity). It seems that the latest versions of Chrome, Firefox and IE can handle this fine (without naticeable delays).Fixes #15396.