This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Update karma so we can remove Safari workaround #16743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narretz
changed the title
Narretz
force-pushed
the
chore-karma-update
branch
from
edabbb0 to
fb649c1
Compare
Narretz
force-pushed
the
chore-karma-update
branch
3 times, most recently
from
276f55a to
5a3108a
Compare
|
with the update, Safari 10 fails every time ... |
Narretz
force-pushed
the
chore-karma-update
branch
from
5a3108a to
1176d17
Compare
Narretz
force-pushed
the
chore-karma-update
branch
from
6c5050e to
14fc726
Compare
mgol
reviewed
Oct 29, 2018
karma-shared.conf.js
Outdated
| version: 'latest-1' | ||
| }, | ||
| 'SL_Safari': { | ||
| base: 'SauceLabs', | ||
| browserName: 'safari', | ||
| platform: 'OS X 10.12', | ||
| platform: 'OS X 10.13', |
There was a problem hiding this comment.
This may start failing soon as Safari 12 might only be available in Mojave (that's how it is in BrowserStack, for example) - i.e. 10.14. Do we have to specify the platform? If the answer's yes, maybe Safari cannot really be used as latest & latest-1 versions...
There was a problem hiding this comment.
The same remark applies to iOS BTW.
There was a problem hiding this comment.
When it starts to fail, we can update it. But I can also try it without the explicit platform.
petebacondarwin
approved these changes
Oct 29, 2018
mgol
approved these changes
Oct 29, 2018
Narretz
force-pushed
the
chore-karma-update
branch
from
98650b4 to
eb37e2d
Compare
This allows us to remove the workaround added in angular#16645
This reverts commit 6b915ad. Karma has this workaround built in since 3.1.0: karma-runner/karma@873e4f9
Safari 10 does not finish the tests, but Safari 11 and 12 do
They take a lot of time since we created different karma jobs for them
Narretz
force-pushed
the
chore-karma-update
branch
7 times, most recently
from
b1294c2 to
349e13f
Compare
Narretz
force-pushed
the
chore-karma-update
branch
from
349e13f to
a376a0f
Compare
Narretz
force-pushed
the
chore-karma-update
branch
5 times, most recently
from
caed010 to
74d9745
Compare
Narretz
force-pushed
the
chore-karma-update
branch
from
012a982 to
f4fc3f5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: