This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(Angular): properly compare RegExp with other objects for equality #11205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else if (isRegExp(o1) && isRegExp(o2)) { | ||
| return o1.toString() == o2.toString(); | ||
| } else if (isRegExp(o1)) { | ||
| return isRegExp(o2) ? o1.toString() == o2.toString() : false; | ||
| } else { | ||
| if (isScope(o1) || isScope(o2) || isWindow(o1) || isWindow(o2) || isArray(o2)) return false; |
There was a problem hiding this comment.
Not the same but a similar bug:
angular.equals({}, /lol/);
There was a problem hiding this comment.
@alexlamsl you are right - going to push an update for those cases as well
pkozlowski-opensource
force-pushed
the
issue11204
branch
from
6cc19c6 to
c850106
Compare
|
@petebacondarwin / @lgalfaso / @Narretz could one of you guys OK this patch? It is pretty minimal and should be fast to review. Thnx! |
|
LGTM |
pkozlowski-opensource
added a commit
that referenced
this pull request
Feb 28, 2015
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11204