input [checkbox] ng-true-value="1" required - never validates

[penfold]

Following changes from 1.2rc2 to 1.2rc3, the behaviour of the checkbox has changed.

An element:

<input type="checkbox" ng-model="terms" ng-true-value="1" required>Check me</input>

Is not valid when it is checked. The function on the checkboxInputType controller function:

  ctrl.$isEmpty = function(value) {
    return value !== trueValue;
  };

Is getting passed value=true when the checkbox is checked. Therefore, the required validation is failing. (true !== "1" is true).

Browser: Chrome & FireFox (latest builds)

[tydanielson]

This is still a problem in 1.2.5

[caitp]

I'm fairly sure this would be closed by #5346 --- care to try it and see? The tests validate it against objects and stuff, so I'm not sure why it wouldn't work in that case

The funny thing is, it's not clear how you make a checkbox "required", there are different semantics for that --- you could say, semantically it must not be indeterminate (must be explicitly checked or unchecked), so it seems a bit off to default to "=== true". But hey, I guess it's probably not too hard to write a custom directive for that one.

[btford]

Closing due to inactivity.

Also I agree with @caitp – I'm not sure such a thing makes sense in core.

[ByScripts]

I really need to use ng-true-value with ng-required. How can I do?

(Tested with Angular 1.3 with success... but I can't use 1.3 because IE8 support is a project requirement)