Skip to content

feat(@angular/cli): support TypeScript 2.4 #6891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(@angular/cli): support TypeScript 2.4 #6891

wants to merge 1 commit into from

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented Jul 5, 2017 •
edited
Loading

Fix #6827

@filipesilva
Copy link
Contributor Author

This PR is up mostly to experiment. It's not meant to go in until Angular itself officially support TS 2.4.

@filipesilva filipesilva requested a review from hansl July 5, 2017 13:57
hansl
hansl suggested changes Jul 5, 2017
View reviewed changes
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit.

packages/@angular/cli/commands/new.ts Outdated
@@ -176,8 +176,8 @@ const NewCommand = Command.extend({
}
});
} else {
createDirectory = mkdir(directoryName)
.catch(err => {
createDirectory = (mkdir as any)(directoryName)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mkdir should be the right type, or the type of denodeify itself is wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that something is wrong with either @types/node or @types/denodeify. I Updated the versions but the error was still there. Added note to explain why it is being typed as any and a TODO for me to fix.

@fxck
Copy link

fxck commented Jul 17, 2017

Any idea when will angular update to 2.4.x?

@filipesilva filipesilva force-pushed the ts-2.4 branch 2 times, most recently from 5daf646 to 37505c1 Compare July 20, 2017 13:27
@filipesilva filipesilva reopened this Jul 20, 2017
@filipesilva filipesilva mentioned this pull request Jul 20, 2017
Merged
@filipesilva filipesilva deleted the ts-2.4 branch July 20, 2017 13:35
@filipesilva
Copy link
Contributor Author

New pr: #7065

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hansl hansl hansl requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typescript 2.4 support
4 participants
@filipesilva @fxck @hansl @googlebot