Skip to content

docs: add story about autoprefixer config #5975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

markgoho
Copy link
Contributor

Those wishing to change which browsers are targeted for when css is prefixed can do so with a simple addition to their package.json file

Those wishing to change which browsers are targeted for when css is prefixed can do so with a simple addition to their package.json file
sumitarora
sumitarora previously approved these changes Apr 17, 2017
@clydin
Copy link
Member

clydin commented Apr 20, 2017

I think the browserslist file may be a cleaner option than the package.json field; especially in regards to overall project readability/discoverability, and more generally, separation of concerns.

Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya, your PR looks good. Thanks for adding this!

Can you also add a link to this guide to the stories list please?
https://github.com/angular/angular-cli/blob/master/docs/documentation/stories.md

@filipesilva
Copy link
Contributor

I also agree with @clydin that using the file is better than changing package.json.

@markgoho
Copy link
Contributor Author

markgoho commented May 5, 2017

@filipesilva I added the link in PR#6188

Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see the link in that new PR. Can you also mention the two ways of setting it please? Package.json and the browserlist file.

@markgoho
Copy link
Contributor Author

markgoho commented May 5, 2017

Changes made -- added the additional option to create a config file.

@filipesilva
Copy link
Contributor

LGTM @markgoho, thanks! CI is failing because of the second commit message, it doesn't fit the required format. If you have time I'd appreciate if you could squash the commits, otherwise I'll do it myself when I merge some other PRs.

@markgoho
Copy link
Contributor Author

markgoho commented May 5, 2017

I'm sorry @filipesilva -- I have no clue how to do that. I've done these PRs directly from github.com and I think squashing has to be done from the command line.

@filipesilva
Copy link
Contributor

No worries, I'll sort it. 👍

filipesilva pushed a commit that referenced this pull request May 8, 2017
Those wishing to change which browsers are targeted for when css is prefixed can do so with a simple addition to their package.json file

Close #5975
filipesilva pushed a commit that referenced this pull request May 8, 2017
Those wishing to change which browsers are targeted for when css is prefixed can do so with a simple addition to their package.json file

Close #5975
filipesilva pushed a commit that referenced this pull request May 8, 2017
Those wishing to change which browsers are targeted for when css is prefixed can do so with a simple addition to their package.json file

Close #5975
@hansl hansl closed this in 2876670 May 9, 2017
@markgoho markgoho deleted the patch-1 branch May 9, 2017 14:19
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
Those wishing to change which browsers are targeted for when css is prefixed can do so with a simple addition to their package.json file

Close angular#5975
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants