-
Notifications
You must be signed in to change notification settings - Fork 12k
Slight update to relative path generation guide #5506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The `README.md` threw me off when trying to generate a module or component that is nested in another module. This update reflects the solution in angular#2136.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
README.md
Outdated
@@ -72,12 +72,9 @@ ng generate component my-new-component | |||
ng g component my-new-component # using the alias | |||
|
|||
# components support relative path generation | |||
# if in the directory src/app/feature/ and you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of deleting these, I suggest you just add your example as the first example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't work though? If I cd
into a subdirectory and generate a component it doesn't actually generate the component in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But they do work, we have tests that verify generation within the folder structure. Because of this I agree with @Meligy that your docs should be in addition to the existing docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm did I just found a bug then? I've tried this feature numerous times but I couldn't actually do this myself. Here's the history
of what I did on 1.0.0
.
ng new test-cli
cd test-cli
cd src
ls
cd app
mkdir feature
cd feature
ng g component new-cmp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyways since it seems to be a possible bug to an intended feature I've changed the PR to add the example instead of replacing it.
The `README.md` threw me off when trying to generate a module or component that is nested in another module. This update reflects the solution in angular#2136. Close angular#5506
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The
README.md
threw me off when trying to generate a module or component that is nested in another module. This update reflects the solution in #2136 (the StackOverflow solution).I don't know if there are plans to rewrite the section here, but if there are just close this PR 😄