-
Notifications
You must be signed in to change notification settings - Fork 12k
docs: add SASS integration #5456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add SASS integration for font-awesome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing instructions work with all of the style options. You can actually mix any of the supported style sheet formats with a single app.
Yes I know, they are instruction to how integrate font-awesome with sass in angular-cli, like they have done with bootstrap's wiki |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please rebase.
Note that this works as well (with no additional changes required):
|
@clydin it does, but showing this setup also helps in other cases where sass doesn't resolve paths. I think it's useful for that. |
add SASS integration for font-awesome Close #5456
add SASS integration for font-awesome Close #5456
add SASS integration for font-awesome Close #5456
Understood and agree. My only concern is that the impression may be given that the described method is the required method. |
add SASS integration for font-awesome Close #5456
As far as usage goes though, there's absolutely no difference between using the .css and .scss in the assets array afaik. So a user that wanted to do something specific with FA, or use it as part of a single sass global style, is better off this way, no? |
Agree :) |
My concern is that someone reading this and wanting to use SCSS in their app may very well think that these steps must be followed to use font-awesome and SCSS in general in their app. Also with the upcoming improvements to |
add SASS integration for font-awesome Close angular#5456
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
add SASS integration for font-awesome