-
Couldn't load subscription status.
- Fork 11.9k
fix(@angular/build): allow custom runner configuration file for unit-test #31603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletions
85
packages/angular/build/src/builders/unit-test/tests/options/runner-config_spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| /** | ||
| * @license | ||
| * Copyright Google LLC All Rights Reserved. | ||
| * | ||
| * Use of this source code is governed by an MIT-style license that can be | ||
| * found in the LICENSE file at https://angular.dev/license | ||
| */ | ||
|
|
||
| import { execute } from '../../index'; | ||
| import { | ||
| BASE_OPTIONS, | ||
| describeBuilder, | ||
| UNIT_TEST_BUILDER_INFO, | ||
| setupApplicationTarget, | ||
| } from '../setup'; | ||
|
|
||
| const VITEST_CONFIG_CONTENT = ` | ||
| import { defineConfig } from 'vitest/config'; | ||
| export default defineConfig({ | ||
| test: { | ||
| reporters: [['junit', { outputFile: './vitest-results.xml' }]], | ||
| }, | ||
| }); | ||
| `; | ||
|
|
||
| describeBuilder(execute, UNIT_TEST_BUILDER_INFO, (harness) => { | ||
| describe('Option: "runnerConfig"', () => { | ||
| beforeEach(() => { | ||
| setupApplicationTarget(harness); | ||
| }); | ||
|
|
||
| describe('Vitest Runner', () => { | ||
| it('should use a specified config file path', async () => { | ||
| harness.writeFile('custom-vitest.config.ts', VITEST_CONFIG_CONTENT); | ||
| harness.useTarget('test', { | ||
| ...BASE_OPTIONS, | ||
| runnerConfig: 'custom-vitest.config.ts', | ||
| }); | ||
|
|
||
| const { result } = await harness.executeOnce(); | ||
|
|
||
| expect(result?.success).toBeTrue(); | ||
| harness.expectFile('vitest-results.xml').toExist(); | ||
| }); | ||
|
|
||
| it('should search for a config file when `true`', async () => { | ||
| harness.writeFile('vitest.config.ts', VITEST_CONFIG_CONTENT); | ||
| harness.useTarget('test', { | ||
| ...BASE_OPTIONS, | ||
| runnerConfig: true, | ||
| }); | ||
|
|
||
| const { result } = await harness.executeOnce(); | ||
|
|
||
| expect(result?.success).toBeTrue(); | ||
| harness.expectFile('vitest-results.xml').toExist(); | ||
| }); | ||
|
|
||
| it('should ignore config file when `false`', async () => { | ||
| harness.writeFile('vitest.config.ts', VITEST_CONFIG_CONTENT); | ||
| harness.useTarget('test', { | ||
| ...BASE_OPTIONS, | ||
| runnerConfig: false, | ||
| }); | ||
|
|
||
| const { result } = await harness.executeOnce(); | ||
|
|
||
| expect(result?.success).toBeTrue(); | ||
| harness.expectFile('vitest-results.xml').toNotExist(); | ||
| }); | ||
|
|
||
| it('should ignore config file by default', async () => { | ||
| harness.writeFile('vitest.config.ts', VITEST_CONFIG_CONTENT); | ||
| harness.useTarget('test', { | ||
| ...BASE_OPTIONS, | ||
| }); | ||
|
|
||
| const { result } = await harness.executeOnce(); | ||
|
|
||
| expect(result?.success).toBeTrue(); | ||
| harness.expectFile('vitest-results.xml').toNotExist(); | ||
| }); | ||
| }); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Not sure how to handle this, but having
typeboth boolean or string will makerunnerConfigconfig not possible to be used from the CLI. As options cannot be eitherbooleanorstring.